Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(card, tile): ajout version sans liens, target blank, et mise à jour des exemples [DS-3359, DS-3330, DS-3387, DS-3362, DS-3358] #657

Merged
merged 8 commits into from
Jul 5, 2023
Merged

🐛 fix(card, tile): ajout version sans liens, target blank, et mise à jour des exemples [DS-3359, DS-3330, DS-3387, DS-3362, DS-3358] #657

merged 8 commits into from
Jul 5, 2023

Conversation

keryanS
Copy link
Contributor

@keryanS keryanS commented Jul 3, 2023

  • Ajout de version carte et tuile sans lien (en noir)
  • Ajout de l'icone target blank sur les cartes avec lien non élargi en target="_blank"
  • Ajout d'exemples de carte et tuile de téléchargement avec remplissage automatique des détails (en Octet ou en Bytes)
  • Ajout d'exemple de carte et tuile de téléchargement avec fichier en langue étrangère
  • Séparation des exemples de tuile de téléchargement
  • Changement des pictogrammes des tuiles de téléchargement
  • Ajustement de la grille dans les exemples de tuiles

@keryanS keryanS added the correctif Quelque chose ne fonctionne pas label Jul 3, 2023
@keryanS keryanS added this to the 1.10.0 milestone Jul 3, 2023
@keryanS keryanS requested a review from lab9fr July 3, 2023 18:20
@keryanS keryanS self-assigned this Jul 3, 2023
@keryanS keryanS changed the title fix(card, tile): sans liens, target blank, ajouts exemples [DS-3359, DS-3330, DS-3387, DS-3362, DS-3358] fix(card, tile): ajout version sans liens, target blank, et mise à jour des exemples [DS-3359, DS-3330, DS-3387, DS-3362, DS-3358] Jul 3, 2023
lab9fr
lab9fr requested changes Jul 4, 2023
View reviewed changes
src/component/card/example/download/sample/sample-no-img.ejs Outdated Show resolved Hide resolved
src/component/card/example/download/sample/sample-no-img.ejs Outdated Show resolved Hide resolved
src/component/card/example/download/sample/sample-lang.ejs Outdated Show resolved Hide resolved
src/component/card/example/download/sample/sample-img.ejs Outdated Show resolved Hide resolved
src/component/card/example/download/sample/sample-img.ejs Outdated Show resolved Hide resolved
src/component/card/example/download/sample/sample-img.ejs Outdated Show resolved Hide resolved
src/component/card/example/download/sample/sample-assess-file.ejs Outdated Show resolved Hide resolved
src/component/card/example/download/sample/sample-assess-file.ejs Outdated Show resolved Hide resolved
@lab9fr lab9fr changed the title fix(card, tile): ajout version sans liens, target blank, et mise à jour des exemples [DS-3359, DS-3330, DS-3387, DS-3362, DS-3358] 🐛 fix(card, tile): ajout version sans liens, target blank, et mise à jour des exemples [DS-3359, DS-3330, DS-3387, DS-3362, DS-3358] Jul 4, 2023
@lab9fr lab9fr changed the base branch from main to dev-1.10.0 July 4, 2023 17:26
@lab9fr lab9fr added Prêt and removed en cours labels Jul 5, 2023
@lab9fr lab9fr merged commit b299109 into dev-1.10.0 Jul 5, 2023
4 checks passed
@lab9fr lab9fr deleted the fix/tile-card-sample branch July 5, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lab9fr lab9fr lab9fr approved these changes

Assignees

@keryanS keryanS

Labels
correctif Quelque chose ne fonctionne pas maj 1.10.0-rc.1 Prêt
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@keryanS @lab9fr