Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(close-btn): retire le margin-left négatif [DS-3522] #784

Merged
merged 2 commits into from
Nov 7, 2023
Merged

🐛 fix(close-btn): retire le margin-left négatif [DS-3522] #784

merged 2 commits into from
Nov 7, 2023

Conversation

zellerbaptiste
Copy link
Contributor

@zellerbaptiste zellerbaptiste commented Sep 11, 2023 •
edited by keryanS
Loading

  • retire le margin-right: -1rem sur le modifier .fr-btn--close et corrige l'impact sur les composants fr-alert, fr-navigation, et fr-notice

@zellerbaptiste zellerbaptiste added correctif Quelque chose ne fonctionne pas à vérifier maj 1.10.1 labels Sep 11, 2023
@zellerbaptiste zellerbaptiste added this to the 1.11.0 milestone Sep 11, 2023
@zellerbaptiste zellerbaptiste self-assigned this Sep 11, 2023
@lab9fr lab9fr added Prêt and removed à valider labels Oct 2, 2023
@keryanS keryanS merged commit dc37ef1 into dev-1.11.0 Nov 7, 2023
4 checks passed
@keryanS keryanS deleted the fix/modal-close-btn-placement branch November 7, 2023 16:41
This was referenced Jul 11, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keryanS keryanS keryanS approved these changes

@lab9fr lab9fr lab9fr approved these changes

Assignees

@zellerbaptiste zellerbaptiste

Labels
correctif Quelque chose ne fonctionne pas maj 1.10.1 Prêt
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zellerbaptiste @lab9fr @keryanS