Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(navigation): correctifs de style mega-menu [DS-3549, DS-3548] #785

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

zellerbaptiste
Copy link
Contributor

@zellerbaptiste zellerbaptiste commented Sep 11, 2023

  • ajoute un margin-top: -1.25rem (-20px) sur le fr-mega-menu__leader
  • passe le texte de description et le lien du fr-mega-menu__leader en taille sm
  • supprime la classe fr-mb-4v de la colonne entourant le fr-mega-menu__leader
  • le texte du bouton de navigation passe en $text-action-high-blue-france à l'ouverture

@zellerbaptiste zellerbaptiste added correctif Quelque chose ne fonctionne pas à vérifier maj 1.10.1 labels Sep 11, 2023
@zellerbaptiste zellerbaptiste added this to the 1.11.0 milestone Sep 11, 2023
@zellerbaptiste zellerbaptiste self-assigned this Sep 11, 2023
@include padding-top(2v);
@include padding-top(0, lg);
@include set-text-margin(0 0 2v);
@include set-title-margin(0 0 2v);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pas besoin du chevron je pense -> juste "p"
  • Nesting de la taille du lien en sm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est corrigé

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utiliser plutot @include nest-link(sm, null); pour le lien

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok c'est remplacé

@include padding-top(2v);
@include padding-top(0, lg);
@include set-text-margin(0 0 2v);
@include set-title-margin(0 0 2v);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utiliser plutot @include nest-link(sm, null); pour le lien

@keryanS keryanS changed the title 🐛 fix(mega-menu): correctifs de style [DS-3549, DS-3548] 🐛 fix(navigation): correctifs de style mega-menu [DS-3549, DS-3548] Nov 9, 2023
@keryanS keryanS merged commit dbd1d90 into dev-1.11.0 Nov 9, 2023
4 checks passed
@keryanS keryanS deleted the fix/navigation-megamenu-spacings branch November 9, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correctif Quelque chose ne fonctionne pas maj 1.10.1 Prêt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants