Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(password): placement checkbox & icon info [DS-3668] #832

Merged
merged 3 commits into from
Nov 28, 2023
Merged

🐛 fix(password): placement checkbox & icon info [DS-3668] #832

merged 3 commits into from
Nov 28, 2023

Conversation

zellerbaptiste
Copy link
Contributor

@zellerbaptiste zellerbaptiste commented Nov 22, 2023 •
edited
Loading

  • met a jour l'icône de message d'information
  • met a jour le placement de la checkbox

@zellerbaptiste zellerbaptiste added correctif Quelque chose ne fonctionne pas en cours maj 1.10.2 labels Nov 22, 2023
@zellerbaptiste zellerbaptiste added this to the 1.11.0 milestone Nov 22, 2023
@zellerbaptiste zellerbaptiste self-assigned this Nov 22, 2023
@zellerbaptiste zellerbaptiste marked this pull request as ready for review November 23, 2023 14:12
@zellerbaptiste zellerbaptiste changed the title 🐛 fix(password): met a jour le composant 🐛 fix(password): mise a jour du composant Nov 23, 2023
lab9fr
lab9fr requested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@lab9fr lab9fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petite proposition de changement qui serait plus clean pour disposition entre le texte de description et la checkbox :
ns(password): row + flex-wrap
checkbox: retrait des margin, flex 0
ns(label): retrait du max-width, flex 1
input: flex 0 1 100%

on en discute si tu veux

@zellerbaptiste
Copy link
Contributor Author

Petite proposition de changement qui serait plus clean pour disposition entre le texte de description et la checkbox : ns(password): row + flex-wrap checkbox: retrait des margin, flex 0 ns(label): retrait du max-width, flex 1 input: flex 0 1 100%

on en discute si tu veux

Ok, merci j'ai intégré tes retours

keryanS
keryanS reviewed Nov 27, 2023
View reviewed changes
src/component/form/deprecated/style/_module.scss
@@ -117,5 +117,5 @@
}

#{ns(info-text)} {
@include icon-image(information-fill, before);
@include icon-image(info-fill, before);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pourquoi info-fill ? c'est plus information-fill ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non l'icône information-fill a un fond de forme ronde alors que info-fill une forme carrée ce que l'on veut dans ce cas.

@lab9fr lab9fr added Prêt and removed à vérifier labels Nov 28, 2023
@keryanS keryanS changed the title 🐛 fix(password): mise a jour du composant 🐛 fix(password): placement checkbox & icon info [DS-3668] Nov 28, 2023
@keryanS keryanS merged commit 15c32b0 into dev-1.11.0 Nov 28, 2023
4 checks passed
@keryanS keryanS deleted the fix/password branch November 28, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keryanS keryanS keryanS approved these changes

@lab9fr lab9fr lab9fr approved these changes

Assignees

@zellerbaptiste zellerbaptiste

Labels
correctif Quelque chose ne fonctionne pas maj 1.10.2 Prêt
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zellerbaptiste @lab9fr @keryanS