Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(navigation): corrige bugs de fermeture du composant [DS-3617, DS-3619] #840

Merged
merged 3 commits into from
Jan 29, 2024
Merged

🐛 fix(navigation): corrige bugs de fermeture du composant [DS-3617, DS-3619] #840

merged 3 commits into from
Jan 29, 2024

Conversation

zellerbaptiste
Copy link
Contributor

@zellerbaptiste zellerbaptiste commented Dec 5, 2023 •
edited
Loading

  • corrige un bug de fermeture au clic Ă  l'extĂ©rieur du composant sur safari
  • corrige un bug de fermeture d'un volet au clic sur un lien ou un bouton Ă  l'intĂ©rieur du composant

@zellerbaptiste zellerbaptiste added correctif Quelque chose ne fonctionne pas à vérifier maj 1.10.2 labels Dec 5, 2023
@zellerbaptiste zellerbaptiste added this to the 1.11.0 milestone Dec 5, 2023
@zellerbaptiste zellerbaptiste self-assigned this Dec 5, 2023
@zellerbaptiste zellerbaptiste changed the title 🐛 fix(navigation): corrige bug de fermeture sur safari [DS-3617] 🐛 fix(navigation): corrige bugs de fermeture du compsant [DS-3617, DS-3619] Dec 6, 2023
@lab9fr lab9fr changed the title 🐛 fix(navigation): corrige bugs de fermeture du compsant [DS-3617, DS-3619] 🐛 fix(navigation): corrige bugs de fermeture du composant [DS-3617, DS-3619] Dec 7, 2023
keryanS
keryanS requested changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@keryanS keryanS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L'ombre du header disparait Ă  la fermeture.

@keryanS keryanS mentioned this pull request Dec 12, 2023
Closed
@keryanS keryanS modified the milestones: 1.11.0, 1.12.0 Dec 12, 2023
@keryanS
Copy link
Contributor

keryanS commented Dec 12, 2023

ProblĂšme d'ombres Ă  l'ouverture et fermeture des menus image

@keryanS
Copy link
Contributor

keryanS commented Dec 13, 2023

ProblĂšme d'ombres Ă  l'ouverture et fermeture des menus image

Ce n'est pas lié à cette correction, bug déja présent

@lab9fr lab9fr modified the milestones: 1.12.0, 1.11.1 Jan 16, 2024
@lab9fr lab9fr added the PrĂȘt label Jan 16, 2024
@keryanS keryanS changed the base branch from main to dev-1.11.1 January 29, 2024 16:44
@keryanS keryanS merged commit 3f07a2b into dev-1.11.1 Jan 29, 2024
4 checks passed
@keryanS keryanS deleted the fix/navigation-closing branch January 29, 2024 16:45
This was referenced Jul 11, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lab9fr lab9fr lab9fr approved these changes

@keryanS keryanS keryanS approved these changes

Assignees

@zellerbaptiste zellerbaptiste

Labels
correctif Quelque chose ne fonctionne pas maj 1.11.0 PrĂȘt
Projects
None yet
Milestone
1.11.1
Development

Successfully merging this pull request may close these issues.
3 participants
@zellerbaptiste @keryanS @lab9fr