Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(analytics): correctif hĂ©ritage listenClick [DS-3745] #885

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

lab9fr
Copy link
Contributor

@lab9fr lab9fr commented Feb 19, 2024

  • corrige un bug js au niveau de l'hĂ©ritage du listenClick. Renommage de la fonction listenClick en listenActionClick car la fonction existe dĂ©ja sur la classe hĂ©ritĂ©e "Instance"

@lab9fr lab9fr added this to the 1.11.2 milestone Feb 19, 2024
@lab9fr lab9fr self-assigned this Feb 19, 2024
@lab9fr lab9fr added correctif Quelque chose ne fonctionne pas à vérifier maj 1.11.1 labels Feb 19, 2024
@zellerbaptiste
Copy link
Contributor

Testé sur Firefox et Safari avec BrowserStack => on ne reproduit plus le bug :
Uncaught TypeError: this._clickTarget.addEventListener is not a function

@lab9fr lab9fr changed the title fix(analytics): correctif hĂ©ritage listenClick 🐛 fix(analytics): correctif hĂ©ritage listenClick Feb 29, 2024
@keryanS keryanS changed the base branch from main to dev-1.11.2 March 1, 2024 11:12
@keryanS keryanS changed the title 🐛 fix(analytics): correctif hĂ©ritage listenClick 🐛 fix(analytics): correctif hĂ©ritage listenClick [DS-3745] Mar 1, 2024
@keryanS keryanS merged commit eac4d5d into dev-1.11.2 Mar 1, 2024
4 checks passed
@keryanS keryanS deleted the fix/analytics branch March 1, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correctif Quelque chose ne fonctionne pas maj 1.11.1 PrĂȘt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants