✨ feat(navigation): permet l'ajout d'icone sur les liens de navigation #913
Conversation
keryanS
added
évolution
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Ajouter des exemples pour visualiser les changements et les valider visuellement :
|
zellerbaptiste
force-pushed
the
feat/nav-link-icon
branch
from
30130f0 to
6e32710
Compare
@keryanS les exemples ont été ajoutés |
|
Rajouter la possibilité de mettre une icone sur les liens du sidemenu, en passant l'élement actif en background image |
petit souci sur la version mobile. |
| } | ||
|
|
||
| const getSubLink = (active = false) => { | ||
| const getSubLink = (active = false, icon, iconPlace) => { |
There was a problem hiding this comment.
ça me fait ticker de voir un argument par défaut en premier
| const getSubLink = (active = false, icon, iconPlace) => { | |
| const getSubLink = (active = false, icon = undefined, iconPlace = 'left') => { |
| @@ -47,12 +50,14 @@ const getMenu = (active = false) => { | |||
| } | |||
| } | |||
|
|
|||
| const getCategory = (active = false) => { | |||
| const getCategory = (active = false, icon, iconPlace) => { | |||
There was a problem hiding this comment.
| const getCategory = (active = false, icon, iconPlace) => { | |
| const getCategory = (active = false, icon = undefined, iconPlace = 'left') => { |
| } | ||
| background-repeat: no-repeat; | ||
| background-position: #{spacing.space(0 3v)}; | ||
| background-size: #{spacing.space(2px calc(100% - 6v))}; |
There was a problem hiding this comment.
idem ici pour le high contrast
| } | ||
| background-repeat: no-repeat; | ||
| background-position: 0 100%; | ||
| background-size: #{spacing.space(100% 0.5v)}; |
There was a problem hiding this comment.
j'ai l'impression que la version high contrast a été retirée sans être remise ailleurs.
Est-elle toujours bien fonctionnelle ?
|
En attente de définition des règles d'usage avec Yves |
|
TODO : Correction mode contrasté |
fr-link--icon-right