đ fix(link, card, tile): enlarge button [DS-3798] #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zellerbaptiste
added
correctif
keryanS
requested changes
Jun 3, 2024
| linkClasses.push(prefix + '-link--download'); | ||
| } | ||
|
|
||
| if (link.assess === true) { |
There was a problem hiding this comment.
le assess file n'est pas possible en button car pas de href
| } | ||
|
|
||
| #{ns(enlarge-button)} { | ||
| @include enlarge('button'); |
There was a problem hiding this comment.
pas besoin de guillemets je pense
lab9fr
reviewed
Jun 3, 2024
| /// @group core | ||
| //// | ||
|
|
||
| #{ns(enlarge-link)} { | ||
| @mixin enlarge($markup) { |
There was a problem hiding this comment.
Suggested change
| @mixin enlarge($markup) { | |
| @mixin enlarge($selector, $markup) { | |
| #{ns('enlarge-$selector') { |
| @@ -38,3 +36,11 @@ | |||
| } | |||
| } | |||
Comment on lines
40
to
42
| #{ns(enlarge-link)} { | ||
| @include enlarge('a'); | ||
| } |
There was a problem hiding this comment.
Suggested change
| #{ns(enlarge-link)} { | |
| @include enlarge('a'); | |
| } | |
| @include enlarge(link, a); |
Comment on lines
44
to
46
| #{ns(enlarge-button)} { | ||
| @include enlarge('button'); | ||
| } |
There was a problem hiding this comment.
Suggested change
| #{ns(enlarge-button)} { | |
| @include enlarge('button'); | |
| } | |
| @include enlarge(button, button); |
keryanS
changed the title
keryanS
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enlarge-buttonutilisée sur les cartes et les tuiles de téléchargement pour élargir la zone de clique à tout le composant quand l'element cliquable est un bouton