Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump rails from 6.0.3.1 to 6.0.3.3 #1134

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Sep 10, 2020

Bumps rails from 6.0.3.1 to 6.0.3.3.

Commits
  • 070d4af v6.0.3.3
  • 4ca2027 Fix XSS vulnerability in translate helper
  • fbe2433 Preparing for 6.0.3.2 release
  • 11052e0 Update changelog
  • 2121b9d Only allow ActionableErrors if show_detailed_exceptions is enabled
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies ruby Pull requests that update Ruby code labels Sep 10, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/rails-6.0.3.3 branch 2 times, most recently from 8a49525 to 0985027 Compare September 11, 2020 10:40
Copy link
Contributor

@alan-gds alan-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like the previous one (#1082), this PR is intermittently segfaulting when running tests. It seems to have passed on Travis this time, but it has failed for me locally; I don't believe it's safe to merge in its current state.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/rails-6.0.3.3 branch from 0985027 to b1a1e6f Compare September 15, 2020 13:35
@alan-gds
Copy link
Contributor

Example of a build where we saw a segfault: https://cd.gds-reliability.engineering/builds/881538

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/rails-6.0.3.3 branch 3 times, most recently from 297e4a0 to b6c43d0 Compare September 18, 2020 15:22
Bumps [rails](https://github.com/rails/rails) from 6.0.3.1 to 6.0.3.3.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v6.0.3.1...v6.0.3.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/rails-6.0.3.3 branch from b6c43d0 to e095527 Compare September 21, 2020 12:20
@koetsier
Copy link
Contributor

koetsier commented Sep 22, 2020

This issue can be reproduced by starting the container using
make serve
and compiling the assets in the container (entering the container using docker exec -it <container-id> /bin/bash)
rake assets:precompile

The solution as suggested here: sass/sassc-rails#122 is to pin Sprockets to version 3.7.2. This seems to solve the problem.

@freesteph freesteph merged commit e095527 into master Sep 22, 2020
@freesteph freesteph deleted the dependabot/bundler/rails-6.0.3.3 branch September 22, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants