Unpin Sprockets gem and upgrade to version 4. #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had this pinned to version 3.7.2 because of a segmentation fault that occurred when upgrading to 4.0+ After investigation it seems that Sprockets now uses the manifest.js file to compile assets instead of the assets.rb file. See: sass/sassc-rails#122 and https://github.com/rails/sprockets/blob/master/UPGRADING.md#manifestjs This commit upgrades Sprockets and now uses the manifest.js file to precompile assets which ensures the segmentation fault no longer occurs.
koetsier
force-pushed
the
unpin_sprockets
branch
from
77cb63f to
174cc31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had this pinned to version 3.7.2 because of a segmentation
fault that occurred when upgrading to 4.0+
After investigation it seems that Sprockets now uses the manifest.js
file to compile assets instead of the assets.rb file.
See: sass/sassc-rails#122 and
https://github.com/rails/sprockets/blob/master/UPGRADING.md#manifestjs
This commit upgrades Sprockets and now uses the manifest.js file
to precompile assets which ensures the segmentation fault no
longer occurs.
Link to Trello card (if applicable): https://trello.com/c/8Datu3zf/121-unpin-sprockets-gem-in-govwifi-admin