-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GW-1916 Combobox updated #2141
base: master
Are you sure you want to change the base?
GW-1916 Combobox updated #2141
Conversation
app/views/super_admin/allowlists/organisation_names/index.html.erb
Outdated
Show resolved
Hide resolved
app/views/super_admin/allowlists/organisation_names/index.html.erb
Outdated
Show resolved
Hide resolved
So when I tested this with JAWS, my screen reader, I navigated to the Allow org allow list page, tabbed to the button which read it out, then on to the combo box, which read out 'Search for existing organisations on GovWifi before adding them' typed in 'UK', eventually it told me the number of results and I could scroll up and down and JAWS would read out the results, no whether it's running it locally that's the issue of the slowness or something up with the JavaScript search script, but in terms of UI, it does now read out the results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to check something, when I open this page it already has an org selected
"Academy for Justice Commissioning"
If this is a searchable feature, I would expect this to be blank. I guess this is a mix of a search and combo box, which might need a blank entry for the first slot, so the user can type in the org name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it now reads fine, and I able able to search, it's still really slow to search, but it could be a local thing to my machine, anyone else see this? (separate issue).
What
On the 'Organisations allow list' page, there is a search combobox that lacks an accessible name, due to the visually associated label 'Search for existing organisations on GovWifi before adding them' not being programmatically associated with the input. Lacking this programmatic association, the accessible name fallbacks to using the placeholder attribute on the input, but this placeholder is empty. Therefore, leaving the input without an accessible name overall. This affects screen reader users, as the input is not labelled and, therefore, its purpose is not programmatically determinable (particularly when browsing out of context), and it also DAC | Accessibility Report 45 affects voice activation users, as there is no programmatic association between the visible label and the input for the user to select the input via its visible label ('click search for existing organisations…').
Why
The label and combobox are not programmatically associated with each other.
Link to JIRA card (if applicable):
GW-1916