Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GW-1924 - Headings and labels - Update confirm rotate radius key #2179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mel-am
Copy link
Contributor

@mel-am mel-am commented Nov 19, 2024

What

Button text was insufficiently descriptive of their topic or purpose, whilst browsing out of
context.

Why

On the 'Rotate secret key' page, neither the page title, error summary nor 'Yes, rotate this
RADIUS key' button identify which location the secret key is to be rotated for.
This affects all users, but the loss of context as to which location the secret key is to be
rotated, the context from the previous step, can particularly affect cognitive and screen
reader users by relying on their memory to remember which location the pronoun 'this' is
referring to.
Link to JIRA card (if applicable):
GW-1924
Screenshot 2024-11-19 at 12 53 06

@mel-am mel-am added bug Something isn't working enhancement New feature or request labels Nov 19, 2024
@mel-am mel-am self-assigned this Nov 19, 2024
@mel-am mel-am requested a review from leonaAtkins November 19, 2024 12:57
@@ -17,5 +17,8 @@

<%= button_to "Yes, rotate this RADIUS key", location_path(@key_to_rotate),
Copy link
Contributor

@leonaAtkins leonaAtkins Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mel, this doesn't read continuously, what I hear is "Yes, rotate this key", then it stops, if I press down I then here for <address>, which feels a bit jarring, and this is because the 'span' is written outside of the button, and indeed form, which you can see if you look at the html output.
I don't think 'button_to' has any aria features, so you may have to 'hand craft' the form and button like.

  <%= form_with(url: @key_to_rotate, method: :patch) do |form| %>
    <div>
      <button class="govuk-button red-button" type="submit" aria-label="Yes, rotate  RADIUS key for <%= @key_to_rotate.address %>"> Yes, rotate this RADIUS key</button>
    </div>
  <% end %>

Warning the above is untested and AI 'may' have helped in its production ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants