Ensure that error pages render the correct error page #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
leonaAtkins
reviewed
Feb 12, 2025
| @@ -49,6 +49,7 @@ def super_admin? | |||
| end | |||
|
|
|||
| def redirect_user_with_no_organisation | |||
| return if current_user.nil? | |||
There was a problem hiding this comment.
Could be a line liner? (untested)
Suggested change
| return if current_user.nil? | |
| return if current_user.nil? || current_user.is_super_admin? && current_organisation.present? |
There was a problem hiding this comment.
Could do, but I'm not sure if it would make the code easier to understand
There was a problem hiding this comment.
the 2 returns could also be confusing. No worries, all good.
koetsier
force-pushed
the
fix_error_page
branch
from
0cf720d to
b01acf5
Compare
leonaAtkins
approved these changes
Feb 13, 2025
koetsier
force-pushed
the
fix_error_page
branch
from
b01acf5 to
6529077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When entering an incorrect route in the admin portal, it returns a 500 error code with a message:
This is an incorrect message and should instead be a message saying that the page does not exist with a 404 error code
Link to JIRA card (if applicable):
https://technologyprogramme.atlassian.net/browse/GW-2100