feat: Light/Dark Presets

[radical4ever]

It would be great if there is an option for applying the settings on both light/dark theme, bc when i edit the theme it just applies it for one theme and makes dark mode not working

[ArtyIF]

Is it possible to do that though with gtk.css? Let me check.

…

On Fri, Jul 22 2022 at 08:10:21 AM -0700, Radical4ever ***@***.***> wrote: It would be great if there is an option for applying the settings on both light/dark theme, bc when i edit the theme it just applies it for one theme and makes dark mode not working — Reply to this email directly, view it on GitHub <#12>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5FPQQS434VDVJDETWH6C3VVK2V3ANCNFSM54L4SRYQ>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ArtyIF]

Since my other email didn't get sent here for some reason - yes, it's possible. Noted.

[radical4ever]

i leave you my gtk.css file that i use for that:
@define-color accent_color @green_4;
@define-color accent_bg_color @green_4;
@define-color window_bg_color;
@define-color window_fg_color;
@define-color headerbar_bg_color;
@define-color headerbar_fg_color;
@define-color popover_bg_color;
@define-color popover_fg_color;
@define-color view_bg_color;
@define-color view_fg_color;
@define-color card_bg_color rgba(255, 255, 255, 0.08);
@define-color

and it works both with adw-gtk3 theme just paste the same file over gtk-3.0

[ArtyIF]

In the meantime copy the gtk.css in gtk-4.0 and gtk-3.0 and rename it gtk-dark.css, that should work

[radical4ever]

Yup, that works for now!

[ArtyIF]

Wait, why would it do that for you? It doesn't for me. It always applies the same theme regardless of the color scheme chosen.

[ArtyIF]

Are you copying those CSS files into your theme or something? Because this program doesn't change the theme files, it just copies the parameters to ~/.config/gtk-4.0/gtk.css (or 3.0 for gtk3). That file is always applied about the selected theme or app's theme (unless the app sets the priority higher like I do, which is technically not recommended) no matter the chosen color scheme.

[radical4ever]

Are you copying those CSS files into your theme or something? Because this program doesn't change the theme files, it just copies the parameters to ~/.config/gtk-4.0/gtk.css (or 3.0 for gtk3). That file is always applied about the selected theme or app's theme (unless the app sets the priority higher like I do, which is technically not recommended) no matter the chosen color scheme.

i dont use a theme or something else, i just add the parameters for the accent color and the rest i leave it empy (so it uses the default value) and then i just save it in ~/.config/gtk-4.0 or gtk-3.0, so it always use the same color on all apps.

[radical4ever]

just save it as gtk.css and put it in gtk-4.0 and that should work on libadwaita apps and for adw-gtk3 i do the same and restart the gtk3 apps

[ArtyIF]

And it doesn't apply when you have it set to dark, right?

…

On Fri, Jul 22 2022 at 10:29:16 AM -0700, Radical4ever ***@***.***> wrote: > Are you copying those CSS files into your theme or something? > Because this program doesn't change the theme files, it just copies > the parameters to ~/.config/gtk-4.0/gtk.css (or 3.0 for gtk3). That > file is always applied about the selected theme or app's theme > (unless the app sets the priority higher like I do, which is > technically not recommended) no matter the chosen color scheme. > i dont use a theme or something else, i just add the parameters for the accent color and the rest i leave it empy (so it uses the default value) and then i just save it in ~/.config/gtk-4.0 or gtk-3.0, so it always use the same color on all apps. — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5FPQUETYOFTJCFFUBUW3DVVLK6ZANCNFSM54L4SRYQ>. You are receiving this because you commented.Message ID: ***@***.***>

[ArtyIF]

just save it as gtk.css and put it in gtk-4.0 and that should work on libadwaita apps and for adw-gtk3 i do the same and restart the gtk3 apps

It's supposed to automatically get put in gtk-4.0 and gtk-3.0.

[radical4ever]

just save it as gtk.css and put it in gtk-4.0 and that should work on libadwaita apps and for adw-gtk3 i do the same and restart the gtk3 apps

It's supposed to automatically get put in gtk-4.0 and gtk-3.0.

oh, sorry! i was talking about the gtk.css file i mentioned earlyer that i made

i leave you my gtk.css file that i use for that: @define-color accent_color @green_4; @define-color accent_bg_color @green_4; @define-color window_bg_color; @define-color window_fg_color; @define-color headerbar_bg_color; @define-color headerbar_fg_color; @define-color popover_bg_color; @define-color popover_fg_color; @define-color view_bg_color; @define-color view_fg_color; @define-color card_bg_color rgba(255, 255, 255, 0.08); @define-color

it just with this one that i made that i dont have the issue but when the app makes its own makes one with only the light theme set.

[ArtyIF]

Ohhhhh. You can change the accent color like that in the app. Press the pencil icon next to the needed values (Accent Standalone Color and Accent Background Color in this case) and enter @green_4. If you want to use a dark theme, use the dropdown in the top to select the dark preset (do it before the @green_4 thing).

…

On Fri, Jul 22 2022 at 10:36:27 AM -0700, Radical4ever ***@***.***> wrote: >> just save it as gtk.css and put it in gtk-4.0 and that should work >> on libadwaita apps and for adw-gtk3 i do the same and restart the >> gtk3 apps >> > It's supposed to automatically get put in gtk-4.0 and gtk-3.0. > oh, sorry! i was talking about the gtk.css file i mentioned earlyer that i made > i leave you my gtk.css file that i use for that: @define-color > accent_color @green_4; @define-color accent_bg_color @green_4; > @define-color window_bg_color; @define-color window_fg_color; > @define-color headerbar_bg_color; @define-color headerbar_fg_color; > @define-color popover_bg_color; @define-color popover_fg_color; > @define-color view_bg_color; @define-color view_fg_color; > @define-color card_bg_color rgba(255, 255, 255, 0.08); @define-color > it just with this one that i made that i dont have the issue but when the app makes its own makes one with only the light theme set. — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5FPQQTJGKP5QTFSUAJHODVVLLZXANCNFSM54L4SRYQ>. You are receiving this because you commented.Message ID: ***@***.***>

[radical4ever]

yeah i know that, but what i mean is that if its possible to made an option to apply both light/dark theme like that.

[ArtyIF]

yeah i know that, but what i mean is that if its possible to made an option to apply both light/dark theme like that.

Like, apply separate color schemes for light and dark themes? Not yet.

[radical4ever]

yeah i know that, but what i mean is that if its possible to made an option to apply both light/dark theme like that.

Like, apply separate color schemes for light and dark themes? Not yet.

not separate, i mean like, an only color for both light/dark theme, without going to edit the 2 themes separately and with that you could switch between theme.

[radical4ever]

maybe i have to make a video to better explain myself 😅🤣

[radical4ever]

this is what i'm trying to mean (i couldnt make a video it stops when i change it)

[ArtyIF]

Same theme for light and dark? It already does that.00:09, July 23, 2022, Radical4ever ***@***.***>: yeah i know that, but what i mean is that if its possible to made an option to apply both light/dark theme like that. Like, apply separate color schemes for light and dark themes? Not yet. not separate, i mean like, an only color for both light/dark theme, without going to edit the 2 themes separately and with that you could switch between theme. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***> -- Sent from Yandex Mail for mobile

[radical4ever]

Same theme for light and dark? It already does that

i mean like an option to apply the colors without doing the same thing on the dark variant

[ArtyIF]

Okay I think I understood what you mean. Have one preset for both light and dark theme so you didn't have to apply a different color scheme when you change the theme. Is that right?

[ArtyIF]

As in, one preset has a variant for light and dark theme, and when applying the scheme, you're still able to switch between light and dark without reapplying the scheme.

[radical4ever]

Okay I think I understood what you mean. Have one preset for both light and dark theme so you didn't have to apply a different color scheme when you change the theme. Is that right?

Yes, is that

[radical4ever]

As in, one preset has a variant for light and dark theme, and when applying the scheme, you're still able to switch between light and dark without reapplying the scheme.

Yeah, something like that

[daudix]

👌

[daudix]

Done!

[daudix]

I've not tested this, but here's how it could be done.

1. Create 2 files containing the light and dark themes. For example: `gtk-light.css` and `gtk-dark.css`.

2. Detect if `gsettings set org.gnome.desktop.interface color-scheme` is set to `'default'` or `'dark'`.

3. If set to dark then symlink `gtk-dark.css` to `gtk.css`, and if default symlink the other file.

What about trying to do this?

[daudix]

Or something like this:
https://github.com/lassekongo83/adw-gtk3/blob/main/gtk4.md

[0xMRTT]

The theme idea is the best one because with this idea, we will be able to customise GNOME shell

[daudix]

Good, one more task for 0.4.0 👍

[ArtyIF]

Yes it is. Noted. On Fri, Jul 22 2022 at 03:13:00 PM +0000, ArtyIF ***@***.***> wrote:

…

Is it possible to do that though with gtk.css? Let me check. On Fri, Jul 22 2022 at 08:10:21 AM -0700, Radical4ever ***@***.***> wrote: > It would be great if there is an option for applying the settings on > both light/dark theme, bc when i edit the theme it just applies it > for one theme and makes dark mode not working > > — > Reply to this email directly, view it on GitHub > <#12>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AB5FPQQS434VDVJDETWH6C3VVK2V3ANCNFSM54L4SRYQ>. > You are receiving this because you are subscribed to this > thread.Message ID: ***@***.***> >

[0xMRTT]

I'm working on this because it's related to #618

[lutzseverino]

How is this going along? This problem should be a priority, since some people switch themes quite often. Night Theme Switcher is rendered useless with Gradience if this persists.

[ArtyIF]

I think this can be worked around by generating two files for light and dark and creating a GApplication that'll switch the gtk.css file periodically. At least, until the recoloring API becomes a thing in the stable version

[daudix]

The problem is that you still need to restart the app, and apps like nautilus will need to be killed every time

[tfuxu]

With current libadwaita implementation of custom themes (or more accurately, a lack of it), it is impossible to add support for seamless transitions between light/dark presets. As noted by daudix, every currently running GTK application on user's system would need to be restarted, or ideally the whole DE session would need to be restarted, making the whole feature very clunky to use.

I'm closing and locking this issue for now, as until AdwColorTheme and its recoloring API becomes available, the discussion here will lead to nothing.
_{If you found some method that could be used / GNOME Team has added some other sort of support for this and we didn't noticed yet, it would be really appreciated if you inform us of your findings on Matrix or on Discussions.}