This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Parse firefox profiles.ini files to get paths of profiles. #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows supporting profiles without a dot in their name, profiles outside of firefox directory and profiles that are symlinked.
0xMRTT
reviewed
Nov 29, 2022
|
@0xMRTT you know better, but it should not break anything, so LGTM! |
daudix
approved these changes
Nov 29, 2022
|
As I can see there isn't any modifications that could result in a break for flatpak. Maybe we should test ? |
|
Oki, give me a few minutes 😉 |
|
Just thinking about it, if someone uses absolute paths in a profile for a flatpaked firefox (with IsRelative=0 in profiles.ini), this could be an issue as absolute paths are not the same inside and outside the flatpak. But I doubt people do that in reality. |
|
Likely no, I doubt a lot of people create additional firefox profiles than a default one. |
daudix
approved these changes
Nov 29, 2022
|
@0xMRTT merging? |
Signed-off-by: 0xMRTT <0xMRTT@proton.me>
|
@jle64 thanks for your contribution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse firefox profiles.ini files to get paths of profiles
This parses firefox profiles.ini files to get the paths of the profiles instead of just treating any subdir of the firefox dir as a profile.
This allows supporting profiles without a dot in their name which the existing glob didn't match which can happen if they are named manually, as well as profiles configured to be outside of the firefox directory that were ignored and profiles that are symlinked (by adding a resolve() on the path before the is_dir()).
There is also an additional try condition to avoid failing for the remaining profiles if encountering a profile without the customChrome.css, as it might be installed on some profiles only.
Changelog
Please note that I have only tested on non-flatpak Firefox.