This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
feat: set activatable widget on action rows #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
FineFindus
changed the title
FineFindus
changed the title
daudix
added a commit
that referenced
this pull request
Jun 26, 2023
## Description Changes the `text-value-toggle` tooltip-text to either display `Show Hex` or `Show Color` depending on which child is currently visible. Depends on #789 ## Type of change <!-- What type of change does your pull request introduce? Put an `x` in the box that apply. --> - [ ] Bugfix (Change which fixes a issue) - [x] New feature (Change which adds new functionality) - [ ] Enhancement (Change which slightly improves existing code) - [ ] Breaking change (This change will introduce incompatibility with existing functionality) ## Changelog <!-- This is optional, but highly appreciated. --> - Improved tooltip for toggling color values ## Testing - [x] I have tested my changes and verified that they work as expected <!-- Make sure you did this step before marking your PR as ready for merge. --> ### How to test the changes <!-- Optional, it can speed up review process if you provide the information on how to test your changes. --> 1. Open the app 2. View tooltip of the `text-value-toggle` button 3. Click the `text-value-toggle ` button 4. Notice how the tooltip changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets the
activatable-widgeton ActionRows, allowing the user to click the row itself to activate the child widget. This brings it more inline with the default libadwaita ActionRows, e.g. ComboRow. It is only done for non-destructible actions.Type of change
Changelog
Testing
How to test the changes