-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome on Gradience. 🥳 We really appreciate your contribution. The core team will review your pull request as soon as possible. You can also join the Matrix room: https://matrix.to/#/#Gradience-space:envs.net or the Discord server: https://discord.com/invite/4njFDtfGEZ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this refactoring job @lavafroth! Overall looks good, but I'll do a proper review tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I've tested everything related to this refactor and it works flawlessly.
Thanks again for this refactor, I didn't thought anyone would be able to decipher this mess I wrote here 😅️
@0xMRTT Any objections, or can we merge this? |
LGTM We can merge ! Thanks for clearing the mess lol |
Description
This PR refactors a few operations to make the code handle edge cases efficiently with marginal performance improvements.
Type of change
Changelog
async_data
inShellTheme
since its members are immutable.async_data
later.Gio.File.make_directory_with_parents
with Python's builtinos.makedirs
withexist_ok
as True to implicitly create directories when nonexistent.KeyError
s when accessing dictionary values, theget
method is used to supply a default value.get
method (which may returnNone
) is coupled with the nullishor
operator to use the value that is notNone
.main_source
attribute as argument to the_compile_sass
function.None
..close()
s on file handles when using context managers.Testing
How to test the changes
Just run
./local.sh