This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
fix: assert write permissions on gnome-shell copy #808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In systems with immutable package stores, the source files used when copying don't have write permissions by default. This creates an error that prevents the files from being removed or altered during the process of the shell theme being built.
Fixed this by creating a copy_function for copytree to set write permissions before performing copying or removing. Additionally I've changed it so that the file is removed if it exists before copying.
Fixes #799
Type of change
Testing
How to test the changes
Build from source, open the application and go to the theming tab, click "apply" next to "Shell Engine Options. You should get a success message.
For those who are using nixos and want to test this, they can use the following package: