Fix the regression of the mainClassName input
#1603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Goooler
changed the title
mainClassName input
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression related to the mainClassName input in the Shadow Gradle plugin's caching functionality. The change ensures proper input tracking for the shadowJar task to maintain correct build cache behavior when the application's main class changes.
- Adds explicit input property tracking for
mainClassNameto the shadowJar task - Sets a default convention value to prevent configuration errors during evaluation
- Re-enables a previously disabled test for main class change caching
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ShadowApplicationPlugin.kt | Adds input property registration and default convention for mainClassName to fix caching regression |
| ShadowJarCachingTest.kt | Re-enables test that was disabled due to the regression, removes unused import |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt
Show resolved
Hide resolved
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1601 (comment).