Skip to content

Use default JavaExec error message when main class is not set #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Goooler merged 3 commits into from
Sep 8, 2025
Merged

Use default JavaExec error message when main class is not set #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6bd987
Use the default error message from JavaExec when main class not set
Goooler Sep 8, 2025
01be908
Update src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/Sha…
Goooler Sep 8, 2025
787b5c7
Refine
Goooler Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changes/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
and `META-INF/groovy` will be merged into `META-INF/groovy/org.codehaus.groovy.runtime.ExtensionModule`.
- Move injecting `Class-Path` manifest attr logic from `doFirst` into `copy`. ([#1720](https://github.com/GradleUp/shadow/pull/1720))
- Deprecate `InheritManifest`. ([#1722](https://github.com/GradleUp/shadow/pull/1722))
- Use default `JavaExec` error message when main class is not set. ([#1725](https://github.com/GradleUp/shadow/pull/1725))

### Fixed

Expand Down
3 changes: 2 additions & 1 deletion ...functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/ApplicationPluginTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ class ApplicationPluginTest : BasePluginTest() {
val result = runWithFailure(runShadowPath)

assertThat(result.output).contains(
"The main class must be specified and not left empty in `application.mainClass` or manifest attributes.",
"Error: Could not find or load main class",
"Caused by: java.lang.ClassNotFoundException:",
)
}

Expand Down
7 changes: 2 additions & 5 deletions src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,9 @@ public abstract class ShadowApplicationPlugin : Plugin<Project> {
tasks.shadowJar.configure { task ->
task.inputs.property("mainClassName", mainClassName)
task.doFirst("Set $mainClassAttributeKey attribute in the manifest") {
val realClass = mainClassName.orNull
// Inject the attribute if it is not already present.
if (!task.manifest.attributes.contains(mainClassAttributeKey)) {
val realClass = mainClassName.orNull
if (realClass.isNullOrEmpty()) {
error("The main class must be specified and not left empty in `application.mainClass` or manifest attributes.")
}
if (!task.manifest.attributes.contains(mainClassAttributeKey) && !realClass.isNullOrEmpty()) {
task.manifest.attributes[mainClassAttributeKey] = realClass
}
}
Expand Down