Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Fix key error for until command, fix output when goal is reached #105

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Fix key error for until command, fix output when goal is reached #105

merged 2 commits into from
Dec 10, 2021

Conversation

TimJentzsch
Copy link
Contributor

Relevant issue: Closes #104.

Description:

  • Fixes a KeyError when formatting the output of /until when the user hasn't transcribed anything recently.
  • Fixes the output of /until when the user has already reached the goal.

Screenshots:

The bot now gives a different message when the goal has already been reached:
The bot responding to /until, saying that u/seeroflights has already reached Ruby.

Checklist:

  • Code Quality
  • Pep-8
  • Tests (if applicable)
  • Success Criteria Met
  • Inline Documentation
  • Wiki Documentation (if applicable)

@TimJentzsch
Fix key error for until command
ebc5a7d 
There was a misnamed format key when the user had zero transcriptions.
@TimJentzsch
Fix until prediction when the goal was already reached
6a96860
@TimJentzsch TimJentzsch requested a review from a team as a code owner December 9, 2021 23:00
@itsthejoker itsthejoker merged commit 5bcb00e into master Dec 10, 2021
@itsthejoker itsthejoker deleted the 104-until-key-error branch December 10, 2021 00:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@itsthejoker itsthejoker itsthejoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix formatting key error for /until command
2 participants
@TimJentzsch @itsthejoker