This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Fix /until crashing if the max rank has already been reached
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the /until command takes the next rank as goal. However, if the maximum rank has already been reached, it would throw an error. Now, it will fall back to the next 10,000 tier.
itsthejoker
reviewed
Jan 4, 2022
| goal_gamma, goal_str = parse_goal_str(next_rank["name"]) | ||
| else: | ||
| # If the user has reached the maximum rank, take the next 10,000 tier | ||
| goal_gamma = ((user["gamma"] + 10_000) // 10_000) * 10_000 |
There was a problem hiding this comment.
I thought "surely there's a better way to do this" and then I looked it up, and there is not a better way to do this. Works for me!
There was a problem hiding this comment.
It definitely felt stupid to write, but I couldn't think of a better way
itsthejoker
approved these changes
Jan 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: Closes #156
Description:
By default, the /until command takes the next rank as goal.
However, if the maximum rank has already been reached, it would throw an error.
Now, it will fall back to the next 10,000 tier.
Screenshots:
Checklist: