This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Add /history command
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimJentzsch
force-pushed
the
21-history-command
branch
from
e4e60ca to
f175ccf
Compare
TimJentzsch
force-pushed
the
21-history-command
branch
from
eb11f03 to
9b83686
Compare
TimJentzsch
force-pushed
the
21-history-command
branch
2 times, most recently
from
024b455 to
d5e194b
Compare
TimJentzsch
force-pushed
the
21-history-command
branch
from
d5e194b to
f028dd4
Compare
MaxVanDeursen
suggested changes
Jul 8, 2021
MaxVanDeursen
suggested changes
Jul 11, 2021
MaxVanDeursen
approved these changes
Jul 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: Closes #21.
Description:
Adds a
/historycommand which creates a plot of the user's gamma over time. Multiple users can be provided to be plotted together.Unfortunately, they are not correct yet due to the wrong dates in the Blossom API (GrafeasGroup/blossom#157).
What's missing in comparison to the old bot is that you can't specify a time frame to restrict the graph to. I am not sure yet how to integrate this properly with the Discord commands, so I want to move this to a separate issue. It's also not used that often, so we can omit it for now.
The command takes about 2.5 seconds for each provided user, which is a bit long. But it's a big improvement to the 45 seconds we had with a previous iteration. Maybe we can optimize the rate command in the API for shorter delays.
Screenshots:
Checklist: