Add /claimed command
#44
Conversation
| # Instead, we ask that the post isn't archived yet. | ||
| # For a short amount of time this might return completed posts. | ||
| submission_response = self.blossom_api.get( | ||
| "submission/", params={"claimed_by": volunteer["id"], "archived": False} |
There was a problem hiding this comment.
Wouldn't it be better to update Blossom with having completed_by as a parameter? This method would be reduced in size quite drastically.
There was a problem hiding this comment.
It does have completed_by, but I can't filter for the value to be NULL, at least AFAIK
There was a problem hiding this comment.
That does make sense... We could make a calculated boolean property which resembles the current state of the post? e.g. unclaimed, in progress, and done, such as the subreddit
| tr_link = f"[Link]({data['transcription']['url']})" | ||
| def to_embed(data: Dict) -> Embed: # noqa: C901 | ||
| """Convert the submission to a Discord embed.""" | ||
| color = Color.from_rgb(255, 176, 0) # Orange |
There was a problem hiding this comment.
I must say that I find this method a bit long and convoluted, since it is doing a lot, from extracting data from a dictionary to picking colors specific to Discord. Would we be able to split these two responsibilities?
| post_list = "\n".join( | ||
| [ | ||
| i18n["claimed"]["post_list_item"].format( | ||
| i + 1, post["tor_url"], post["url"] |
There was a problem hiding this comment.
Do we want some pagination/limit here? I can already see a problem with 100 claimed messages flashing before my eyes :P
|
@TimJentzsch is this still needed? |
|
Yes, I am currently working on a PR to Blossom that simplifies the |
|
The find command will get reworked, and this probably too. I will implement that later, probably in a new PR and maybe after we release Buttercup. |
Relevant issue: Closes #43.
Description:
Adds a
/claimedcommand to view the commands claimed by the given user.Ideally we merge #34 before this one and then add the user extraction from that PR to the
/claimedcommand as well.Screenshots:
Checklist: