Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Add /until command #52

Merged
merged 11 commits into from
Nov 17, 2021
Merged

Add /until command #52

merged 11 commits into from
Nov 17, 2021

Conversation

TimJentzsch
Copy link
Contributor

@TimJentzsch TimJentzsch commented Jul 12, 2021

Relevant issue: Closes #38.

Description:

Adds an /until command to predict how long it will take to reach a certain gamma score or flair rank.

Note: This PR has been assembled over a longer time frame, with a big merge commit in-between. I think a thorough review would be good to avoid unexpected behavior/bugs. There might also be some line-ending changes (CLRF to LF), I advice turning off the whitespace diff in GitHub (settings cog) if that happens.

Screenshots:

The /until command in action. Predictions to reach Topaz for u/seeroflights

Future Work

The following features will be moved to separate issues / PRs:

  • Providing different time frames to calculate the rate on (probably using a similar system as for /history and /rate.
  • Providing a user as goal. The bot will then calculate when the user with lower gamma will catch up with the user with higher gamma, taking both their transcribing rates into account.
  • Drawing a graph for the predictions. It should include the history graph for the user in the time frame that the rate is calculated on and a dotted line for the predicted transcribing rate until the goal is reached.

Checklist:

  • Code Quality
  • Pep-8
  • Tests (if applicable)
  • Success Criteria Met
  • Inline Documentation
  • Wiki Documentation (if applicable)

@TimJentzsch TimJentzsch marked this pull request as ready for review November 17, 2021 17:01
@TimJentzsch TimJentzsch requested a review from a team as a code owner November 17, 2021 17:01
@itsthejoker
Copy link
Member

plz resolve conflicts

@itsthejoker itsthejoker merged commit 8faa7a0 into master Nov 17, 2021
@itsthejoker itsthejoker deleted the 38-until-command branch November 17, 2021 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add /until command
2 participants