This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
Black #129
Closed
Black #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned | random.choice(config.no_gifs) | ||
| ) | ||
| ) | ||
|
|
||
| return | ||
|
|
||
| logging.debug( | ||
| f'Now executing command {requested_command},' | ||
| f' by {reply.author.name}.' | ||
| f"Now executing command {requested_command}," f" by {reply.author.name}." |
There was a problem hiding this comment.
This right here is an error, as far as the python interpreter is concerned.
I noticed the same when I was running black on the celery rewrite code, noticing it wasn't perfect at rewriting the multi-line string stuff or understanding f-strings.
There was a problem hiding this comment.
Hmm. Looks like this is a known bug. psf/black#369
There was a problem hiding this comment.
Looks like even that is a duplicate of a long(ish)-standing bug: psf/black#26
TheLonelyGhost
suggested changes
Jul 4, 2018
|
Closing because change is stale. Will need to address the issue and merge it quickly since it touches so many files and has a high potential for merge conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#127
This is a "hey, let's see what it looks like and if we want to go this route" kind of PR. If we don't like it, we can close it, no big deal.
This is the result of running:
black setup.py && black torin the root directory, using the default configurations for Black. Honestly I do kind of like how it turned out, but I'm curious as to your thoughts.