Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/pass flake8 linting #14

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

frank113
Copy link
Contributor

@frank113 frank113 commented Jun 26, 2023

Summary

This PR solves CI errors seen in the most recent master commit as of June 25 2023 . The changes in this PR spawned from work on issue #11 (PR incoming) when updating workflows to run linting and tests.

Changes Made

  1. Address flake8 errors in:
  • docs/conf.py
  • examples/urls.py
  • regexfactory/__init__.py

To validate these changes execute run the following commands:

pip install flake8 black pylint isort
flake8 ## to check flake8 globally
black regexfactory --check
isort regexfactory --check
pylint regexfactory

Considerations

  • This PR must be merged before the upcoming pytest pull request.

Other

I am excited to contribute to this package! Regular expressions can be a pain in the behind and this package simplifies the regex experience.

@frank113 frank113 marked this pull request as draft June 26, 2023 05:18
@frank113 frank113 marked this pull request as ready for review June 26, 2023 05:32
@GrandMoff100 GrandMoff100 merged commit 7a40feb into GrandMoff100:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants