Don't define different classes for each character #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the
chars.py
, you define custom classes for each special character. This is very weird behavior as it defies the purpose of classes in the first place. Each class should be a template and it is expected to be instantiated multiple times making different objects based on that blueprint. Making class singletons like these should generally be discouraged.I've also removed the
RegexChar
class as a whole, since it was basically doing the same thing asRegexPattern
except it was only supposed to contain one character (which wasn't actually enforced by the class).