Skip to content

Commit

Permalink
Fixed bug/issue affecting the msw port in PipeDialog causing navigati…
Browse files Browse the repository at this point in the history
…on with Next button to set percussive as yes.
  • Loading branch information
larspalo committed Jul 11, 2024
1 parent 9461a0b commit 4ac09e2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Bug that caused a read label placement at the last column to be invalid.
- Crash happening on windows port if organ tree had wrong focus when opening an .organ file.
- Copy pipe offset feature to also set HasIndependentRelease value from source pipe to target(s).
- Issue/Bug on the msw port in the PipeDialog that would cause forcing selection of IsPercussive=Y when navigating with "Next" button to the last pipe

## [0.14.0] - 2024-07-02

Expand Down
6 changes: 4 additions & 2 deletions src/PipeDialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -624,12 +624,16 @@ Pipe* PipeDialog::GetPipePointer(unsigned index) {

void PipeDialog::SetButtonState() {
if (m_selectedPipeIndex == 0) {
if (m_prevPipeBtn->HasFocus())
m_nextPipeBtn->SetFocus();
m_prevPipeBtn->Disable();
} else if (m_selectedPipeIndex > 0) {
m_prevPipeBtn->Enable();
}

if (m_selectedPipeIndex == (m_rank_pipelist.size() - 1)) {
if (m_nextPipeBtn->HasFocus())
m_prevPipeBtn->SetFocus();
m_nextPipeBtn->Disable();
} else if (m_selectedPipeIndex < (m_rank_pipelist.size() - 1)) {
m_nextPipeBtn->Enable();
Expand All @@ -645,11 +649,9 @@ void PipeDialog::TransferPipeValuesToWindow() {
}
if (m_currentPipe->isPercussive) {
m_isPercussiveYes->SetValue(true);
// m_isPercussiveNo->SetValue(false);
m_hasIndependentReleaseYes->Enable();
m_hasIndependentReleaseNo->Enable();
} else {
// m_isPercussiveYes->SetValue(false);
m_isPercussiveNo->SetValue(true);
m_hasIndependentReleaseYes->Enable(false);
m_hasIndependentReleaseNo->Enable(false);
Expand Down

0 comments on commit 4ac09e2

Please sign in to comment.