Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrandOrguePerf issue #1280

Closed
rousseldenis opened this issue Nov 26, 2022 · 4 comments · Fixed by #1306
Closed

GrandOrguePerf issue #1280

rousseldenis opened this issue Nov 26, 2022 · 4 comments · Fixed by #1306
Milestone

Comments

@rousseldenis
Copy link
Contributor

@oleg68 In my tests peregrinations, I wanted to launch GrandOrguePerfTest.

It seems that all tests are failing.

Do you know if those ones have to be updated or if there is a real performance problem on the current version?

@oleg68
Copy link
Contributor

oleg68 commented Nov 26, 2022

@rousseldenis I think is an incorrect behavior of GrandOrguePerfTest: it marks all mesure results as errors.

@larspalo could tell more.

@larspalo
Copy link
Contributor

That the test fail is normal - but they should return a number at what point they fail! You see, the test is about at what point does the output fail, and you get a number at approximate that number of polyphony (for each setting) that you'll start to get xruns.

@oleg68
Copy link
Contributor

oleg68 commented Nov 27, 2022

@larspalo So they are not errors. They should be information messages that at this level of polyphony the error occurs high probably.

@oleg68 oleg68 added this to the 3.9.3 milestone Nov 27, 2022
@larspalo
Copy link
Contributor

@oleg68 Right, the output of perftest is perhaps a bit cryptic, but the bottom line is that the test is done in such a way that the engine is driven until failure - that is the very point of the tool. The limit if found when an error is produced. How this is presented to the user is certainly possible to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants