Panic button hangs

[willeke1234]

If I forget to connect my Bluetooth MIDI devices, I use the Panic button to rescan the MIDI devices. Every now and then, GO hangs when I press the Panic button. Steps to reproduce:

1. Load a sample set (demo).
2. Hit the Panic button repeatedly.

or

1. Load a sample set (demo).
2. Pull all the stops and press all keys.
3. Hit the Panic button.
4. Repeat step 2 and 3.

GO 3.13.2

Samples.zip

[oleg68]

1. MacOs?
2. Did this issue experience with 3.13.1?
3. Do you use RtAudio or PortAudio?

[willeke1234]

1. Yes, macOS 14 and macOS 10.15
2. GO 3.13.0 (macOS 14) and GO 3.7 (macOS 14 and macOS 10.15) also hang.
3. GO 3.13.2 uses PortAudio and GO 3.7 uses RtAudio.

[oleg68]

@willeke1234 could you test my attemt to fix this issue https://github.com/oleg68/GrandOrgue-official/tree/bugfix/panic-hang ?

If GrandOrgue still hangs please attach the stacktrace.

[willeke1234]

@oleg68 After pressing the panic button, GO sometimes hangs or starts making a horrible noise, as if a small piece of sound is being played repeatedly.

The samples:
Test 1, PortAudio, GO hangs, two samples of the same hang.
Test 2, PortAudio, sample 1 after the noise started. Sample 2 when GO hangs (after some Panics).
Test 3, RtAudio core, the same symptoms as test 2. Sample 1 after the noise started. Sample 2 when GO hangs.

Edit: I forgot to add the samples
Samples.zip

[oleg68]

@willeke1234 Lets continue our iterations at #1736