Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default MIDI settings not applied where there is a default .cmb file #1785

Closed
ahall41 opened this issue Jan 27, 2024 · 3 comments · Fixed by #1865
Closed

Default MIDI settings not applied where there is a default .cmb file #1785

ahall41 opened this issue Jan 27, 2024 · 3 comments · Fixed by #1865
Milestone

Comments

@ahall41
Copy link

ahall41 commented Jan 27, 2024

Where there is a default combination file, containing (say) combination or tuning settings only, which is then loaded on startup, the default MIDI settings (keyboard, swell, GC, etc), should also be applied.

@ahall41
Copy link
Author

ahall41 commented Jan 29, 2024

A few more "oddities" where there is a default .cmb

  • Unless (I assume) the organ is installed in exactly the same folder as when the .cmb is created, you get a message 'The .cmb file does not exactly match ...'
  • Reset to Defaults is enabled, but if you use it, you get an error deleting the .cmb which you haven't (yet) saved.

@ahall41
Copy link
Author

ahall41 commented Feb 21, 2024

Some suggestions:

  1. As well as importing a default .cmb settings, also import a default .yaml with the same name as the .organ
  2. If the .cmb file does no contain a midi (or key stroke) setting, apply the default after import (including import settings)
  3. OR Apply defaults after importing a default cmb (but not after a saved .cmb)
    I think it can be assumed that, by and large, the defaults are what the user wants to use?

@oleg68 oleg68 added this to the 3.14.1 milestone Feb 25, 2024
@oleg68
Copy link
Contributor

oleg68 commented Apr 5, 2024

  1. As well as importing a default .cmb settings, also import a default .yaml with the same name as the .organ

There is no any reason of importing a default .yaml because the combinations can be stored in the default .cmb.

oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Apr 6, 2024
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Apr 11, 2024
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Apr 12, 2024
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Apr 13, 2024
oleg68 added a commit that referenced this issue Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants