Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename classes and source files to have the GO prefix #816

Closed
oleg68 opened this issue Oct 31, 2021 · 0 comments · Fixed by #839
Closed

Rename classes and source files to have the GO prefix #816

oleg68 opened this issue Oct 31, 2021 · 0 comments · Fixed by #839
Assignees
Milestone

Comments

@oleg68
Copy link
Contributor

oleg68 commented Oct 31, 2021

Aggording to #793 it has decided, that all GrandOrgue classes should have the single GO prefix.

  1. All classes and files started with GOrgue should be renamed to start with GO (remove rgue).

  2. All classes and files started with GrandOrgue should be renamed to start with GO.

  3. The files should be renamed to correspond to the class names

  4. The names of header files with these prefixes not containing any classes should be converted to lowercase with the prefix go_

  5. Not to forget to rename include protection variables:

    #ifndef GORGUESTOP_H
    #define GORGUESTOP_H
    

    to

    #ifndef GOSTOP_H
    #define GOSTOP_H
    
@oleg68 oleg68 added this to the 3.4.2 milestone Oct 31, 2021
@oleg68 oleg68 self-assigned this Nov 4, 2021
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Nov 6, 2021
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Nov 6, 2021
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Nov 10, 2021
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Nov 10, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant