Fixed loading an organ when some configuration entry is out of range https://github.com/GrandOrgue/grandorgue/issues/1696

[oleg68]

Resolves: #1696

This PR changes handling of Out of range configuration errors dramatically.

Earlier loading the organ was finishing. Now the default value is used for this configurantion entry and loading the organ continues. An error message appears in the Log window.

I'm not sure that the new behavior does not cause unattended side effects.

[oleg68]

@larspalo could you approve this PR?

[larspalo]

@oleg68 I don't like this at all. The out of range checking is there for very good reasons for the .odf. If, and I mean only really if, we should apply such "default value instead when out of range" strategy, it should really be limited to only "some configuration entries" and not all of them. If for instance a too big switch number is referenced as a GUI element it currently would default to the first (switch) instead - which is most certainly not intended.

Personally, I think that this new loose out of range checking would perhaps be ok for .cmb settings mostly, that are supposed to have been written by GO itself, the .odf should be strictly correct to begin with.

[oleg68]

Personally, I think that this new loose out of range checking would perhaps be ok for .cmb settings mostly, that are supposed to have been written by GO itself, the .odf should be strictly correct to begin with.

@larspalo

I restored the strict checking of .odf file. Now grandorg assumes the default value only if a .cmb the value is out of range.

[oleg68]

@larspalo could you approve this PR?