Fixed saving Max release tail to the organ preset https://github.com/GrandOrgue/grandorgue/issues/1804 #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larspalo
approved these changes
Apr 11, 2024
oleg68
force-pushed
the
bugfix/saving-max-release-tail
branch
from
784882b to
a8be424
Compare
|
This is closely related to #1368. Would it be possible to consider that issue in the future? |
oleg68
force-pushed
the
bugfix/saving-max-release-tail
branch
from
a8be424 to
d49f5ad
Compare
|
@rousseldenis could you approve this PR? |
rousseldenis
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1804
Earlier the release tail length was a GrandOrgue config option. If an organ had the
Maxvalue in it's preset, the GrandOrgue config option was used. It made unabl to setMaxfor particular organs.Now the release tail length only presents in organ settings, not in the GrandOrgue config. It always reset when another organ is loaded.