Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed changing sound of a playing pipe without Pipe999IsTremulant when a wave tremulant state is changed https://github.com/GrandOrgue/grandorgue/issues/1855 #1872

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fixed changing sound of a playing pipe without Pipe999IsTremulant when a wave tremulant state is changed https://github.com/GrandOrgue/grandorgue/issues/1855 #1872

merged 1 commit into from
Apr 17, 2024

Conversation

oleg68
Copy link
Contributor

@oleg68 oleg68 commented Apr 11, 2024

Resolves: #1855

This PR fixes a sound artifact when changing a wave tremulant state. For this it

  • adds a member GOSOundSample::m_WaveTremulantStateFor for saving the Pipe999IsTremulant value of current sounding loop
  • Renames
    • GOSoundingPipe::m_Sampler to p_CurrentLoopSampler
    • GOSoundEngine::StartTaskSample to CreateTaskSample
    • GOSoundEngine::SwitchAttackSampler to SwitchToAnotherAttack
  • Introduces
    • GOSoundProvider::IsWaveTremulant
    • GOSoundProvider::IsWaveTremulantStateSuitable
  • Removes GOSoundingPipe::m_IsWaveTremulantActive in favor of m_SoundProvider.IsWaveTremulant()
  • Addes checking of Pipe999IsTremulant of the current sounding loop in GOSoundingPipe::SetWaveTremulant

@oleg68 oleg68 requested review from larspalo and rousseldenis April 11, 2024 17:30
@oleg68 oleg68 mentioned this pull request Apr 11, 2024
Merged
5 tasks
@oleg68
Copy link
Contributor Author

oleg68 commented Apr 17, 2024

@larspalo @rousseldenis could you approve this PR?

@oleg68 oleg68 merged commit b753b7b into GrandOrgue:master Apr 17, 2024
1 check passed
@oleg68 oleg68 deleted the bugfix/trem branch April 17, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larspalo larspalo larspalo approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wave tremulant on/off affects pipes that should not be affected.
3 participants
@oleg68 @larspalo @rousseldenis