Fixed hang if there were lots of unused ODF entries https://github.com/GrandOrgue/grandorgue/issues/1918

[oleg68]

Resolves: #1918

After #1774 GrandOrgue started ignoring Pipe999ReleaseCrossfadeLength if there were multiple releases. It caused generating lots of warning messages in the log window.

Under windows displaying thousands of messages caused hang.

This PR introduces a limit of 3000 "unused" messages that avoids the hang.

[oleg68]

@larspalo @rousseldenis Could you approve this PR?

[rousseldenis]

@oleg68 I had already wondered how user interface should be improved for those warnings.

I'm thinking that warnings could be displayed in a separate windows being called in Settings or ...

Instead displaying the popup, we could add a statusbar on the main window. That should be more user friendly with better user experience?. What do you think about ?

[oleg68]

@rousseldenis This PR only fixes the hang on Windows. Improving the UI is the subject of a separate discussion.

[rousseldenis]

@rousseldenis This PR only fixes the hang on Windows. Improving the UI is the subject of a separate discussion.

Yes of course. I wanted to write my thoughts down looking at the code as this is more a 'workaround' as the limit is harcoded and could change depending the execution environment.