Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepared to a new release #2076

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Prepared to a new release #2076

merged 1 commit into from
Jan 1, 2025

Conversation

oleg68
Copy link
Contributor

@oleg68 oleg68 commented Dec 27, 2024

No description provided.

@rousseldenis
Copy link
Contributor

@oleg68 I see you changed minor version. What do you plan to put in it?

@rousseldenis
Copy link
Contributor

That comment as I thought about the change on Mac supported version. IMHO, those kind of change should not be included in patch versions. At minimum a minor version, better major version, in order to give a clean signal to user

@oleg68
Copy link
Contributor Author

oleg68 commented Jan 1, 2025

@oleg68 I see you changed minor version. What do you plan to put in it?

You can see this plan at https://github.com/GrandOrgue/grandorgue/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.16.0

@oleg68
Copy link
Contributor Author

oleg68 commented Jan 1, 2025

That comment as I thought about the change on Mac supported version. IMHO, those kind of change should not be included in patch versions. At minimum a minor version, better major version, in order to give a clean signal to user

Yes, you are right.

Unfortunally, building for old macos versions on github takes lots of effort (mostly due the lack of support from homebrew), so we will break it often in the future.

@willeke1234 may be you know a good way of installing old dependencies? There is a docker/podman container technology for linux that allows to freeze the old images and to use them for building. But is it possible for macos?

@oleg68
Copy link
Contributor Author

oleg68 commented Jan 1, 2025

@rousseldenis I share your concerns on breaking the macos 12 support in 3.15.4. But do you have any reasons not to make 3.16.0? If no, could you approve this PR?

@rousseldenis
Copy link
Contributor

@rousseldenis I share your concerns on breaking the macos 12 support in 3.15.4. But do you have any reasons not to make 3.16.0? If no, could you approve this PR?

No, just wanted to highlight some releasing flow care about major/minor/patch

@oleg68 oleg68 merged commit 60208d5 into GrandOrgue:master Jan 1, 2025
1 check passed
@willeke1234
Copy link
Contributor

@willeke1234 may be you know a good way of installing old dependencies? There is a docker/podman container technology for linux that allows to freeze the old images and to use them for building. But is it possible for macos?

I have no idea. Better ask @MStraeten or @Benitoite.

@MStraeten
Copy link

MStraeten commented Jan 2, 2025

if you’re using homebrew then you can’t build for an older macOS than the build system. The GitHub runners can’t be changed that easily.
If you want to build for an older macOS you might use a local macports environment (there you can set a development target - you should do it also in /opt/local/etc/macports.conf)

these steps I used building an arm64 version:
first install dependencies (since I have a build environment for darktable and lilypond, these are just the additional dependencies - maybe there are further dependencies, so you need to check the output of the cmake command)

sudo port install cmake gettext docbook-xsl-nons pkgconfig fftw-3 wxWidgets-3.2 wavpack yaml-cpp imagemagick jack fftw-3-single
sudo port select --set wxWidgets wxWidgets-3.2

then switch to the build directory wherever you extracted the grandorgue source package
cd src/grandorgue/build

cmake .. \
-DWAVPACK_LIBRARIES="-L/opt/local/lib -lwavpack" \
-DDOCBOOK_DIR=/opt/local/share/xsl/docbook-xsl-nons \
-DCMAKE_OSX_DEPLOYMENT_TARGET=11.1 \
-DCMAKE_BUILD_TYPE=Release \
-G "Unix Makefiles"

if that step indicates missing dependencies, you can install those via `sudo port install …`
if you’re justbbuilding for your os, you can ditch the line -DCMAKE_OSX_DEPLOYMENT_TARGET=11.1 \
make

@oleg68
Copy link
Contributor Author

oleg68 commented Jan 2, 2025

@MStraeten

first install dependencies

This is the hardest step on github runner, because homebrew does not work for old macos versions.

My question was about is there a way to install dependencies from homebrew for macos 13 now, when it works an to save the result to an "image", that we can use in the future, even when 13 is dessuported.

Docker is such technology for linux. But I don't know, is there any analogues for MacOs?

@MStraeten
Copy link

there aren‘t different dependencies - using a recent XCode16 with recent updates sdk allows to build for macOS back to 10.14. macports is able to support this, homebrew isn‘t.
I don’t know, if macOS can be run properly in a docker container. But it’s possible to run an older macOS in an UTM virtual machine on a recent M1-4 Mac. Using Rosetta it’s possible to build also for x86_64 architecture on a silicon Mac (at least with macports - I’m not using homebrew, so no experience with that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants