Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added asio image on the about screen #848

Merged
merged 4 commits into from
Nov 14, 2021
Merged

Added asio image on the about screen #848

merged 4 commits into from
Nov 14, 2021

Conversation

oleg68
Copy link
Contributor

@oleg68 oleg68 commented Nov 14, 2021 •
edited
Loading

Resolves: #823

This PR is created as a replacement of #824

It is based on @rousseldenis changes.

Please review it.

@oleg68 oleg68 added this to the 3.4.2 milestone Nov 14, 2021
@oleg68
Copy link
Contributor Author

oleg68 commented Nov 14, 2021

After this PR the about screen looks like:

On windows: splash-win

On linux: splash-linux

larspalo
larspalo approved these changes Nov 14, 2021
View reviewed changes
Copy link
Contributor

@larspalo larspalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's excellent that the information is included when asio is included in the build and otherwise not. Good work!

@oleg68 oleg68 merged commit 0314fd0 into GrandOrgue:master Nov 14, 2021
@oleg68 oleg68 deleted the add_asio_about-dro branch November 14, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larspalo larspalo larspalo approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees

@larspalo larspalo

@rousseldenis rousseldenis

Labels
needs review
Projects
None yet
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.

ASIO: Add image to 'About'
3 participants
@oleg68 @larspalo @rousseldenis