Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Error when navigating out from Grapes with something selected. #2953

Closed
cartifon opened this issue Aug 11, 2020 · 2 comments
Closed

BUG: Error when navigating out from Grapes with something selected. #2953

cartifon opened this issue Aug 11, 2020 · 2 comments

Comments

@cartifon
Copy link

Hey @artf,

Steps:
Open Canvas with GrapesJS, select any of the components, then click on Go to Random, I get an error that says "Cannot read property 'models' of undefined".

This only happens if I call the editor.destroy() before navigating to a different page. But if I remove the destroy, it works fine...
Demo: https://stackblitz.com/edit/grapesjs-models

Should I really call the destroy()? Will I have any issue on opening GrapesJS multiples times if I don't destroy it?

@artf
Copy link
Member

artf commented Aug 27, 2020

Thanks @cartifon should be fixed in the next release

@artf artf closed this as completed in 0be9ea2 Aug 28, 2020
vijayshukla30 pushed a commit to vijayshukla30/grapesjs that referenced this issue Sep 7, 2020
@Nelida27
Copy link

Hello,
I have the same problem now that I moved to latest version.
Should I call editor.destroy()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants