Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: PropertyComposite with slider for four sides (L,R,T,B). Change in one slider causes other values to reset. #4965

Closed
2 tasks done
RohitLad opened this issue Mar 8, 2023 · 0 comments
Closed
2 tasks done

BUG: PropertyComposite with slider for four sides (L,R,T,B). Change in one slider causes other values to reset. #4965

RohitLad opened this issue Mar 8, 2023 · 0 comments
Labels
bug

Comments

@RohitLad
Copy link

RohitLad commented Mar 8, 2023

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Safari

Reproducible demo link

https://codesandbox.io/s/funny-williamson-thb52d?file=/index.js

Describe the bug

How to reproduce the bug?

  1. Go to https://codesandbox.io/s/funny-williamson-thb52d?file=/index.js

What is the expected behavior?
select the default component and have a look at style manager. When one slider (for eg. Bottom padding) is moved, the other sliders should stay at the predefined or constant value. Funnily enough, it all works fine if the type is 'number' instead of a 'slider'

What is the current behavior?
When one slider is moved (eg. Bottom padding), even the other sliders move and their values are reset.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@RohitLad RohitLad changed the title BUG: PropertyComposite with slider for four sides (L,R,T,B). Change in a slider causes other values to reset. BUG: PropertyComposite with slider for four sides (L,R,T,B). Change in one slider causes other values to reset. Mar 8, 2023
@artf artf added the bug label Mar 11, 2023
@artf artf closed this as completed in a2ca4b1 Mar 11, 2023
artf added a commit that referenced this issue May 2, 2023
@artf @wilsonsergio2500
@lexoyo @Zaxcoding @estebgonza @xQwexx @jacobisknight @timgates42 @himansh-gjr @Singwai @PaulRill00
Merge dev (#5087)
6c00bf9 
* fix for when no implicit type (#4903)

fix for no implicit type

Co-authored-by: Sergio Wilson <sergio.wilson@foxpoint.com>

* Fix broken links in the docs (#4914)

* moved repo from artf to GrapesJS 1st pass

* exceptions

* Fix typing of trigger to include `args` (#4910)

* Fix typing of trigger to include `args`

* Update index.d.ts

I don't even know how this got here haha

* Remove ComponentLabelView hotfix for the tagName

* TS Types: Extends the type of property that scripts/styles can takes (#4924)

chore(types): Extends the type of property that scripts and styles can take

* Convert Trait test into TS (#4899)

Co-authored-by: Artur Arseniev <artur.catch@hotmail.it>

* Clear deferred stuff on editor destroy. Fixes #4940

* Remove unused stuff from Editor

* Add new `noCustom` option to `Component.getName()`

* Up jsdoc

* Add `rename` method to SelectorManager

* Use rename in ClassTagView

* Add duplicateSelected

* Update Components.md (#4952)

Grammer correction for Component Recognition and Component Type Stack section

* Fix typos

* docs: Fix a few typos (#4957)

There are small typos in:
- docs/api/selector.md
- docs/api/storage_manager.md
- docs/modules/Blocks.md
- docs/modules/Components.md
- docs/modules/I18n.md
- docs/modules/Storage.md
- docs/modules/Traits.md

Fixes:
- Should read `argument` rather than `argumnet`.
- Should read `with` rather than `wiht`.
- Should read `redundant` rather than `redundent`.
- Should read `propagation` rather than `propogation`.
- Should read `performances` rather than `perfomances`.
- Should read `implementation` rather than `implemenation`.
- Should read `contributors` rather than `contributos`.
- Should read `attached` rather than `attacched`.

Signed-off-by: Tim Gates <tim.gates@iress.com>

* Fix broken links in the docs (#4963)

* docs: Fix broken link of Storage

* docs: Fix broken link of Blocks

* docs: Fix broken link of Style-manager

* docs: Fix broken link of Commands

* docs: Fix broken link of Assets

---------

Co-authored-by: Artur Arseniev <artur.catch@hotmail.it>

* Fix link in Assets doc

* Fix slider in StyleManager. Closes #4965

* Fix checkbox trait values on undo/redo. Closes #4972

* Add `fetchOptions` to AssetManager configs

* Fix sorter placeholder with grid elements. Closes #4991

* Module cleanup (#4985)

* module cleanup

* Fix ??

---------

Co-authored-by: Artur Arseniev <artur.catch@hotmail.it>

* improve typing (#5010)

* Add options to ExportTemplate command

* Fix showOffsetsSelected. Closes #4998

* fix: resolved bug with top/left being sticky when resizing from l/t side

* Prevent top/left update if not in standard drag mode

* Up Resizer dim values

* Up key for the partial update

* Build

* Up docs

* Add TS

* Remove previous index.d.ts

* Update README links

* Add getValue/setValue to Trait

* Improve TS for `Components.addType`. Closes #5053

---------

Signed-off-by: Tim Gates <tim.gates@iress.com>
Co-authored-by: Sergio Wilson <wilsonsergio2500@gmail.com>
Co-authored-by: Sergio Wilson <sergio.wilson@foxpoint.com>
Co-authored-by: Alex Hoyau <a.hoyau@silexlabs.org>
Co-authored-by: Zach Sadler <zaxcoding@gmail.com>
Co-authored-by: Esteban Gonzalez <32603471+estebgonza@users.noreply.github.com>
Co-authored-by: Alex Ritter <alex@undo.app>
Co-authored-by: jacobisknight <jacob@sotechworks.com>
Co-authored-by: Tim Gates <tim.gates@iress.com>
Co-authored-by: Himansh <77732259+himansh-gjr@users.noreply.github.com>
Co-authored-by: Singwai Chan <c.singwai@gmail.com>
Co-authored-by: Paul Rill <paulrill2000@outlook.com>
This was referenced May 24, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artf @RohitLad