Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing the visibility of the property, to avoid unwanted visible style options #2497

Merged
merged 1 commit into from
Jan 12, 2020

Conversation

jcamejo
Copy link
Contributor

@jcamejo jcamejo commented Jan 8, 2020

Hi @artf I hope you are having a great start of the year.

I've found out a small issue regarding the Style Manager. If the Style Manager panel is not set as active on editor load and there's a property that has been setup as unstylable in any component, the property will still be visible but unable to make changes.

I've added this line to avoid this issue, let me know if this has a better fit somewhere else.

Here are the steps to reproduce the issue I'm talking about:

STEPS TO REPRODUCE

  1. Pull the last changes from the dev branch.
  2. In src/panels/config.js, removed the active property from the style manager configuration.
  3. In src/dom_components/model/Component.js, mark any currently visible property as unstylable, in my case I've added the 'float' property.
  4. Reload the editor, select any component with the disabled property and open the style manager, the property will still be present but unable to make changes.

Let me know what you think.

Thanks!

@jcamejo jcamejo changed the title refreshing the visibility on property load, to avoid unwanted visible… Refreshing the visibility of the property, to avoid unwanted visible style options Jan 8, 2020
@artf
Copy link
Member

artf commented Jan 12, 2020

Good catch Juan, thanks

@artf artf self-assigned this Jan 12, 2020
@artf artf merged commit 4f007f3 into GrapesJS:dev Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants