Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dist from src #6041

Merged
merged 3 commits into from
Aug 7, 2024
Merged

refactor: remove dist from src #6041

merged 3 commits into from
Aug 7, 2024

Conversation

danstarns
Copy link
Member

@danstarns danstarns commented Aug 6, 2024

This PR removes the dist from source control. We should build the source from a unified machine and not expect it to come from a devs machine.

@artf an open discussion on whether this would be a breaking change? - Could users be pointing to the git URL?

Copy link
Member

@artf artf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was a mistake from the beginning keeping the dist folder in the source. Point directly to the GitHub URL file was also never recommended, so let's go with the cleanup 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants