init: pnpm setup #6114
Merged
init: pnpm setup #6114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danstarns
commented
Sep 3, 2024
| @@ -36,32 +36,21 @@ | |||
| "backbone-undo": "0.2.6", | |||
| "codemirror": "5.63.0", | |||
| "codemirror-formatting": "1.0.0", | |||
| "html-entities": "~1.4.0", | |||
There was a problem hiding this comment.
@artf this is needed to stop error:
Looks like we should keep it.
danstarns
commented
Sep 3, 2024
| "format": "prettier . --write", | ||
| "format:check": "prettier . --check" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
Most of the dev deps for typescript, testing, building, and lining are now in this file.
danstarns
commented
Sep 3, 2024
| }, | ||
| "pnpm": { | ||
| "peerDependencyRules": { | ||
| "ignoreMissing": [ |
There was a problem hiding this comment.
They are hoisted to the root.
danstarns
commented
Sep 3, 2024
| "eslint": "8.57.0", | ||
| "eslint-config-prettier": "9.1.0", | ||
| "eslint-plugin-jest": "28.8.0", | ||
| "eslint-plugin-prettier": "5.1.3", | ||
| "grapesjs-cli": "4.1.3", |
There was a problem hiding this comment.
There is a conflict in the repo with webpack, as vuepress relies on a different version of webpack as to grapesjs-cli, we can resolve this better and share webpack when we have the cli in the monorepo.
danstarns
commented
Sep 3, 2024
| "documentation": "14.0.3", | ||
| "postcss": "8", | ||
| "sass": "1.42.1", | ||
| "vuepress": "1.9.10", |
artf
reviewed
Sep 3, 2024
artf
reviewed
Sep 3, 2024
artf
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR implements the following changes:
It sets up the workspace as a monorepo containing two packages:
grapesjs(published)@grapesjs/docs(non-published)Both packages are managed through the root pnpm monorepo, including linting, shared dependencies, and build steps.
Why?
We have a collection of repositories in our organization that depend on either the GrapesJS core or the GrapesJS CLI. Each repo currently contains slightly different versions and collections of issues. By moving these packages together, we aim to achieve:
We chose pnpm because:
workspaces:@package resolution mechanism.Usage
For detailed usage instructions, please refer to the updated CONTRIBUTING.md file in this branch.
Related