Skip to content

Wheel build for 8.0.0 on macos x86_64 is failing tests #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eriknw opened this issue May 22, 2023 · 2 comments · Fixed by #101
Closed

Wheel build for 8.0.0 on macos x86_64 is failing tests #89

eriknw opened this issue May 22, 2023 · 2 comments · Fixed by #101

Comments

@eriknw
Copy link
Member

eriknw commented May 22, 2023

See: https://github.com/GraphBLAS/python-suitesparse-graphblas/actions/runs/5035542365/jobs/9031130433

Raw log attached for posterity: macos_x86_64_log.txt

Looks like something bad is happening in test_matrix_binfile_read_write.

@eriknw
Copy link
Member Author

eriknw commented Jun 3, 2023

I'm not sure if there is anything useful here, but I dumped the JIT config for the failing wheel build: https://github.com/GraphBLAS/python-suitesparse-graphblas/actions/runs/5161271671/jobs/929812306

===================================
  Printing default JIT configurations
  -----------------------------------
  JIT_C_CONTROL on
  JIT_USE_CMAKE False
  JIT_C_COMPILER_NAME /Applications/Xcode_14.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
  JIT_C_COMPILER_FLAGS -arch x86_64 -O3 -DNDEBUG -Xclang -fopenmp -I/usr/local/opt/libomp/include  -fPIC  -arch x86_64  -isysroot /Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk 
  JIT_C_LINKER_FLAGS -L/usr/local/opt/libomp/lib -dynamiclib 
  JIT_C_LIBRARIES  -lm -ldl -lomp
  JIT_C_CMAKE_LIBS m;dl;omp
  JIT_C_PREFACE 
  JIT_ERROR_LOG 
  JIT_CACHE_PATH /Users/runner/.SuiteSparse/GrB8.0.1
  ===================================

@alugowski
Copy link
Collaborator

alugowski commented Jun 3, 2023

Anecdotally I noticed that, at least for C++, builds on macOS seem to be a lot less tolerant of things like out-of-bounds memory accesses. Even reads. Usually on Linux and Windows you have to write to an entirely different page to trigger a segfault, it seems like surprisingly often a single byte out of range is enough to crash on AppleClang/macOS.

So maybe this is an upstream bug in eWiseMult that is just being caught on this platform. The JIT is new code, after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants