Run add_arm_to_libomp_dylib.sh only on arm64 #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change shouldn't hurt anything. Probably won't help though. |
Thanks for the quick reply. I suspected as much (and you're right--doesn't help). The annoying thing is that I haven't been able to reproduce the bug locally. Now that pre-release wheels are pushed, I hope this will be easier to investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #87; I'm not sure whether we should run
add_arm_to_libomp_dylib.shon macos x86_64, or only arm64. @alugowski, what do you think?We have a failure on macos x86_64; see #89. If this PR doesn't help, I think I'll release a (probably) broken package to allow us and users to investigate further.