-
Notifications
You must be signed in to change notification settings - Fork 7
Update to SuiteSparse:GraphBLAS 9.1.0 #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alugowski @michelp I made some progress updating The wheel builds are failing (hooray for tests!), and I'm wondering if either of you could help take a look (I'm busy traveling this week and next week). Changes:
|
I can take a look this weekend. To get rid of the macos OMP hack we'll need to use the new runners as per actions/runner-images#9254 |
FYI I've had good experience using scikit-build-core for cmake-based projects. Better try fixing what we have first, but might be worth considering for any future refactor. |
Would it be possible to make this into a branch on this repo so I'm able to add commits? |
The latest updates to the cmake build system for GraphBLAS (and all of SuiteSparse) is very stable now. So any changes you need to make would also work for a long time, for future updates to my codes. |
Done. |
Great! I pushed changes to that branch that appear to work. Sorry I don't think it's possible to update the PR to be from that branch instead of the one from your fork, so I opened a new PR #128 Let's move discussion there. |
No description provided.