Modernize: use pyproject.toml for more things, add pre-commit; remove versioneer #67
Conversation
… versioneer - Move metadata and config to `pyproject.toml` (and flake8 config to `.flake8`) - Use `setuptools-git-versioning` instead of `versioneer.py` - Add `.pre-commit-config.yaml` for git pre-commit hooks - Add GitHub Action to run pre-commit hooks to check linting
|
Oh nice. I'm happy to rebase the other PR on this when you're happy with it. Yeah, the sdist is built with It's probably broken in the same way as the existing one: needs GraphBLAS but doesn't include it. |
Cool. I think I'm happy with it. Won't know for certain unless it works with your PR 🤣 . Shall I go ahead and merge? I built this PR on conda-forge, and everything worked except the version (which is expected--it should work in normal situations).
sdists are meant for redistributors. It's not supposed to have GraphBLAS included. Even a clever individual should be able to install the sdist using their local installation of GraphBLAS--probably just need to set some environment variables. We test sdist installs in |
|
Great! I'll work on the cibuildwheel PR soon. The linter change is nice. It still provides questionable demands, but at least now they come quickly instead of at the end of a long build :) |
pyproject.toml(and flake8 config to.flake8)setuptools-git-versioninginstead ofversioneer.py.pre-commit-config.yamlfor git pre-commit hooksAddresses some of #65, but we're still using
setuptools. Hopefully I didn't screw anything up.CC @alugowski, this may help with the version issues in #66. How do you build sdist and wheels?
build --sdistandbuild --wheelor similar?