Build non-Arm wheels using CI #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump version for testpypi * Update for linux images * Enable linux aarch64, disable osx-arm64 * Bunch of changes from scikit-learn's file * Undo last changes
* Bump version for testpypi * Update for linux images * Enable linux aarch64, disable osx-arm64 * Bunch of changes from scikit-learn's file * Undo last changes * Try to see what is modifying repo
* Bump version for testpypi * Update for linux images * Enable linux aarch64, disable osx-arm64 * Bunch of changes from scikit-learn's file * Undo last changes * Try to see what is modifying repo * Modify dirty string
* Bump version for testpypi
* Update for linux images
* Enable linux aarch64, disable osx-arm64
* Bunch of changes from scikit-learn's file
* Undo last changes
* Try to see what is modifying repo
* Modify dirty string
* Try ignoring GraphBLAS-{version}/ checkout folder
* Bump version for testpypi
* Update for linux images
* Enable linux aarch64, disable osx-arm64
* Bunch of changes from scikit-learn's file
* Undo last changes
* Try to see what is modifying repo
* Modify dirty string
* Try ignoring GraphBLAS-{version}/ checkout folder
* Just keep swimming
* Bump version for testpypi
* Update for linux images
* Enable linux aarch64, disable osx-arm64
* Bunch of changes from scikit-learn's file
* Undo last changes
* Try to see what is modifying repo
* Modify dirty string
* Try ignoring GraphBLAS-{version}/ checkout folder
* Just keep swimming
* Moar dtypes!
eriknw
reviewed
Mar 28, 2023
There was a problem hiding this comment.
I left a couple minor questions and nits.
I'm curious how tests are included in the package now and whether pytest --pyargs suitesparse_graphblas still runs them.
Looks great! Thanks so much @jim22k and @alugowski!
I hope we can figure out arm builds soon, but this is a huge step for us even w/o arm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates updates by @alugowski and refines a few things to properly extract the tag when building wheels.
For now, non-Arm packages are disabled, but the goal is to include them in the future once build issues can be resolved.