Skip to content

Include tests as a module in the package #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Mar 30, 2023

In response to the comment here:
#66 (comment)

I would like to investigate and understand the issue with running tests as part of cibuildwheel.

@eriknw
Copy link
Member Author

eriknw commented Mar 30, 2023

This seems to work for me. @jim22k, shall we merge and cut another alpha release?

This will get rid of this deprecation warning: https://github.com/GraphBLAS/python-suitesparse-graphblas/actions/runs/4567035158/jobs/8060334816#step:4:3275

/tmp/pip-build-env-zspslfc4/overlay/lib/python3.8/site-packages/setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning: Installing 'suitesparse_graphblas.tests' as data is deprecated, please list it in packages.

@jim22k
Copy link
Member

jim22k commented Mar 30, 2023

Have you actually built wheels with these changes?
The easiest way is to manually trigger the deployment on your forked repo on github.com

@eriknw
Copy link
Member Author

eriknw commented Mar 30, 2023

Have you actually built wheels with these changes?
The easiest way is to manually trigger the deployment on your forked repo on github.com

Sort of. I didn't tag it, so the version was wrong so that test failed, but the other tests ran and passed:
https://github.com/eriknw/python-suitesparse-graphblas/actions/runs/4568482219

I can do a tag on my own repo to upload to test.pypi if you'd like.

@jim22k
Copy link
Member

jim22k commented Mar 30, 2023

No, it looks like it worked enough to try out a merge + pre-release tag.

@eriknw eriknw merged commit 611bb44 into GraphBLAS:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants